Return proxied response body for all status codes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosiac1
force-pushed
the
feat/fix-500-on-404
branch
2 times, most recently
from
6164141
to
9828ce4
Compare
|
Found that Updated Created #154 |
mosiac1
force-pushed
the
feat/fix-500-on-404
branch
from
9828ce4
to
9c133e6
Compare
mosiac1
changed the title
Randgalt
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a missing bucket/key will result in a 500 with the error "Insufficient content written 0 < x" (where X is a the expected content size) which seems to be a Jetty error.
The aws-proxy correctly logs that the response from MinIO has status
404and theContent-Lengthheader is set. With a breakpoint I confirmed that the response from MinIO has the same size asContent-Length, so I'm not sure why Jetty doesn't get any content.Will continue investigating.