Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better handling internal and remote errors #154

Open
mosiac1 opened this issue Sep 19, 2024 · 1 comment
Open

Add better handling internal and remote errors #154

mosiac1 opened this issue Sep 19, 2024 · 1 comment

Comments

@mosiac1
Copy link
Contributor

mosiac1 commented Sep 19, 2024

Discussion originally started from: #153.

aws-proxy used to only forward the bodies of 2XX responses, otherwise sending just the headers. This was changed by the PR above to always forward the bodies, regardless of the status code.

Additionally, if an error is raised internally in aws-proxy (e.g., a server error causing a 500 or an access control check failing causing a 403) these send HTML bodies.

Most S3 clients do expect errors to have an XML body with more details but can also handle missing or badly formatted bodies (the status code is enough to raise an exception). Having no details for errors does make it harder to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@mosiac1 and others