Import JRuby implementation #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fig GH-104 lib/fiddle/jruby.rb is based on https://github.com/jruby/jruby/blob/master/lib/ruby/stdlib/fiddle/jruby.rb . Here are changes for it: * Move `Fiddle::TYPE_*` to `Fiddle::Types::*` * Add `Fiddle::Types::VARIADIC` * Add `Fiddle::Types::CONST_STRING` * Add `Fiddle::Types::BOOL` * Add `Fiddle::Types::INT8_T` * Add `Fiddle::Types::UINT8_T` * Add `Fiddle::Types::INT16_T` * Add `Fiddle::Types::UINT16_T` * Add `Fiddle::Types::INT32_T` * Add `Fiddle::Types::UINT32_T` * Add `Fiddle::Types::INT64_T` * Add `Fiddle::Types::UINT64_T` * Add more `Fiddle::ALIGN_*` for the above new `Fiddle::Types::*` * Add more `Fiddle::SIZEOF_*` for the above new `Fiddle::Types::*` * Add support for specifying type as not only `Fiddle::Types::*` but also `Symbol` like `:int` * Add support for variable size arguments in `Fiddle::Function` * Add `Fiddle::Closure#free` * Add `Fiddle::Closure#freed?` * Add `Fiddle::Error` as base the error class * Add `Fiddle::Pointer#call_free` and stop using `FFI::AutoPointer` in `Fiddle::Pointer` * Add support for `Fiddle::Pointer.malloc {}` `Fiddle::Pointer` * Add support for `Fiddle::Pointer#free=` * Add `Fiddle::Pointer#freed?` * Use binary string not C string for `Fiddle::Pointer#[]` * Add `Fiddle::Handle.sym_defined?` * Add `Fiddle::Handle#sym_defined?` * Add `Fiddle::Handle::DEFAULT` * Add `Fiddle::ClearedReferenceError` * Add no-op `Fiddle::Pinned` Some features are still "not implemented". So there are some "omit"s for JRuby in tests.
kou
commented
Sep 28, 2024
| @@ -49,6 +49,11 @@ def test_class_size_with_count | |||
| end | |||
|
|
|||
| def test_set_ctypes | |||
| if RUBY_ENGINE == "jruby" and Fiddle::WINDOWS | |||
| omit("JRuby's 'l!' pack string is buggy. " + | |||
| "See https://github.com/jruby/jruby/issues/8357 for details") | |||
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-104
lib/fiddle/jruby.rb is based on
https://github.com/jruby/jruby/blob/master/lib/ruby/stdlib/fiddle/jruby.rb .
Here are changes for it:
Fiddle::TYPE_*toFiddle::Types::*Fiddle::Types::VARIADICFiddle::Types::CONST_STRINGFiddle::Types::BOOLFiddle::Types::INT8_TFiddle::Types::UINT8_TFiddle::Types::INT16_TFiddle::Types::UINT16_TFiddle::Types::INT32_TFiddle::Types::UINT32_TFiddle::Types::INT64_TFiddle::Types::UINT64_TFiddle::ALIGN_*for the above newFiddle::Types::*Fiddle::SIZEOF_*for the above newFiddle::Types::*Fiddle::Types::*but alsoSymbollike:intFiddle::FunctionFiddle::Closure#freeFiddle::Closure#freed?Fiddle::Erroras base the error classFiddle::Pointer#call_freeand stop usingFFI::AutoPointerinFiddle::PointerFiddle::Pointer.malloc {}Fiddle::PointerFiddle::Pointer#free=Fiddle::Pointer#freed?Fiddle::Pointer#[]Fiddle::Handle.sym_defined?Fiddle::Handle#sym_defined?Fiddle::Handle::DEFAULTFiddle::ClearedReferenceErrorFiddle::PinnedSome features are still "not implemented". So there are some "omit"s for JRuby in tests.