Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import TruffleRuby implementation #148

Draft
wants to merge 1 commit into
base: truffleruby-base
Choose a base branch
from
Draft

Conversation

kou
Copy link
Member

@kou kou commented Sep 29, 2024

Fix GH-145

lib/fiddle/truffleruby.rb is based on
https://github.com/oracle/truffleruby/blob/master/lib/truffle/truffle/fiddle_backend.rb
.

Here are changes for it:

  • Add Fiddle::Types::VARIADIC
  • Add Fiddle::Types::CONST_STRING
  • Add Fiddle::Types::BOOL
  • Add Fiddle::ALIGN_BOOL
  • Add Fiddle::SIZEOF_BOOL
  • Add Fiddle::SIZEOF_CONST_STRING
  • Add support for specifying type as not only Fiddle::Types::* but also
    Symbol like :int
  • Add Fiddle::Error as base the error class
  • Add support for Fiddle::Pointer.malloc {}
    Fiddle::Pointer
  • Add support for Fiddle.free(#to_int)
  • Accept Fiddle::Function(need_gvl:) but it's just ignored
  • Fiddle::Function#initialize: Add an argument validation
  • Fiddle::Function#initialize: Keep arguments as instance variables for
    getters
  • Add support for Fiddle::Handle.sym
  • Add support for Fiddle::Handle.[]
  • Add support for Fiddle::Handle.sym_defined?
  • Add support for Fiddle::Handle#sym
  • Add support for Fiddle::Handle#[]
  • Add support for Fiddle::Handle#sym_defined?
  • Add support for Fiddle::Pointer.malloc
  • Add support for Fiddle::Pointer.to_ptr(#to_ptr)
  • Add support for Fiddle::Pointer#free=
  • Add Fiddle::Pointer#freed?
  • Add support for Fiddle::Pointer#call_free
  • Add support for Fiddle::Pointer#to_i
  • Add support for Fiddle::Pointer#to_int
  • Add support for Fiddle::Pointer#ptr
  • Add support for Fiddle::Pointer#+@
  • Add support for Fiddle::Pointer#ref
  • Add support for Fiddle::Pointer#-@
  • Add support for Fiddle::Pointer#null?
  • Add support for Fiddle::Pointer#to_s
  • Add support for Fiddle::Pointer#to_str
  • Add support for Fiddle::Pointer#inspect
  • Add support for Fiddle::Pointer#<=>
  • Add support for Fiddle::Pointer#==
  • Add support for Fiddle::Pointer#eql?
  • Add support for Fiddle::Pointer#+
  • Add support for Fiddle::Pointer#-
  • Add support for Fiddle::Pointer#[]=
  • Add support for Fiddle::Pointer#size
  • Add support for Fiddle::Pointer#size=
  • Add Fiddle::ClearedReferenceError
  • Add no-op Fiddle::Pinned
  • Add Fiddle::NULL

Some features are still "not implemented". So there are some "omit"s
for TruffleRuby in tests.

Fix GH-145

lib/fiddle/truffleruby.rb is based on
https://github.com/oracle/truffleruby/blob/master/lib/truffle/truffle/fiddle_backend.rb
.

Here are changes for it:

* Add `Fiddle::Types::VARIADIC`
* Add `Fiddle::Types::CONST_STRING`
* Add `Fiddle::Types::BOOL`
* Add `Fiddle::ALIGN_BOOL`
* Add `Fiddle::SIZEOF_BOOL`
* Add `Fiddle::SIZEOF_CONST_STRING`
* Add support for specifying type as not only `Fiddle::Types::*` but also
  `Symbol` like `:int`
* Add `Fiddle::Error` as base the error class
* Add support for `Fiddle::Pointer.malloc {}`
  `Fiddle::Pointer`
* Add support for `Fiddle.free(#to_int)`
* Accept `Fiddle::Function(need_gvl:)` but it's just ignored
* `Fiddle::Function#initialize`: Add an argument validation
* `Fiddle::Function#initialize`: Keep arguments as instance variables for
  getters
* Add support for `Fiddle::Handle.sym`
* Add support for `Fiddle::Handle.[]`
* Add support for `Fiddle::Handle.sym_defined?`
* Add support for `Fiddle::Handle#sym`
* Add support for `Fiddle::Handle#[]`
* Add support for `Fiddle::Handle#sym_defined?`
* Add support for `Fiddle::Pointer.malloc`
* Add support for `Fiddle::Pointer.to_ptr(#to_ptr)`
* Add support for `Fiddle::Pointer#free=`
* Add `Fiddle::Pointer#freed?`
* Add support for `Fiddle::Pointer#call_free`
* Add support for `Fiddle::Pointer#to_i`
* Add support for `Fiddle::Pointer#to_int`
* Add support for `Fiddle::Pointer#ptr`
* Add support for `Fiddle::Pointer#+@`
* Add support for `Fiddle::Pointer#ref`
* Add support for `Fiddle::Pointer#-@`
* Add support for `Fiddle::Pointer#null?`
* Add support for `Fiddle::Pointer#to_s`
* Add support for `Fiddle::Pointer#to_str`
* Add support for `Fiddle::Pointer#inspect`
* Add support for `Fiddle::Pointer#<=>`
* Add support for `Fiddle::Pointer#==`
* Add support for `Fiddle::Pointer#eql?`
* Add support for `Fiddle::Pointer#+`
* Add support for `Fiddle::Pointer#-`
* Add support for `Fiddle::Pointer#[]=`
* Add support for `Fiddle::Pointer#size`
* Add support for `Fiddle::Pointer#size=`
* Add `Fiddle::ClearedReferenceError`
* Add no-op `Fiddle::Pinned`
* Add `Fiddle::NULL`

Some features are still "not implemented". So there are some "omit"s
for TruffleRuby in tests.
@kou kou marked this pull request as draft September 29, 2024 09:28
@kou
Copy link
Member Author

kou commented Sep 29, 2024

This is based on GH-147. So we should not merge this before GH-147.

@eregon eregon changed the base branch from master to truffleruby-base October 1, 2024 12:20
@eregon
Copy link
Member

eregon commented Oct 1, 2024

I changed the target branch so this PR shows the relevant diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The fiddle gem is broken on truffleruby and jruby
2 participants