Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the vacuum grippers (only EPick at the moment) #175

Open
wants to merge 3 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

jproberge
Copy link
Contributor

This PR provides support for the Robotiq vacuum grippers. It has already been successfully tested on the EPick gripper, but it should also work for the Airpick (never tested though).

There is a video showing this specific package in action here. I'd be very happy if someone could review / test this so that we can merge it for customers using these grippers. Please don't hesitate to ask questions or to make any comments. Thanks!

@li2jq
Copy link

li2jq commented Jul 3, 2020

Hi @jproberge
Do you fix this problem for your customer?

_File "/home/li2jq/catkin_ws/src/robotiq-kinetic-devel/robotiq_modbus_rtu/src/robotiq_modbus_rtu/comModbusRtu.py", line 95, in getStatus
 output.append((response.getRegister(i) & 0xFF00) >> 8)
AttributeError: 'ModbusIOException' object has no attribute 'getRegister'_

Also from your last comment, you made a patch to temporarily solve this problem. Could you provide the detailed instructions about this patch? Like where to add/change/delete the code. Thank you!

Best regards
Jiqing Li

li2jq
li2jq previously approved these changes Jul 3, 2020
@jproberge
Copy link
Contributor Author

Hi @jproberge
Do you fix this problem for your customer?

_File "/home/li2jq/catkin_ws/src/robotiq-kinetic-devel/robotiq_modbus_rtu/src/robotiq_modbus_rtu/comModbusRtu.py", line 95, in getStatus
 output.append((response.getRegister(i) & 0xFF00) >> 8)
AttributeError: 'ModbusIOException' object has no attribute 'getRegister'_

Also from your last comment, you made a patch to temporarily solve this problem. Could you provide the detailed instructions about this patch? Like where to add/change/delete the code. Thank you!

Best regards
Jiqing Li

Hello @li2jq ,

Since you are not the only person having this problem and that it seems to affect some EPick vacuum grippers, I've added a patch that works on all grippers and should fix the problem for you (and others who have the same issue). If you have time, could you try this PR and review it? Thanks for your feedback!

@ljden
Copy link

ljden commented May 6, 2021

Any progress on this PR?

Copy link

@Mahdiford Mahdiford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Epick. README update for beginners would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants