Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1832] Duplicate RepoSense links #2243

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions frontend/src/components/c-footer.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<template lang="pug">
#footer
#app-name
span &nbsp;
a(
v-bind:href="getRepoSenseHomeLink()", target="_blank"
)
strong RepoSense
span &nbsp;|&nbsp;
a(
v-bind:href="getSpecificCommitLink()", target="_blank"
)
strong Version
span &nbsp;|&nbsp;
a(
v-bind:href="getUserGuideLink()", target ="_blank"
)
strong User Guide
</template>


<script lang='ts'>
import { defineComponent } from 'vue';

export default defineComponent({
name: 'c-footer',
methods: {
getRepoSenseHomeLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.HOME_PAGE_URL}/RepoSense/`;
}
return `${window.HOME_PAGE_URL}`;
},

getSpecificCommitLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.REPOSENSE_REPO_URL}`;
}
if (version.startsWith('v')) {
return `${window.REPOSENSE_REPO_URL}/releases/tag/${version}`;
}
return `${window.REPOSENSE_REPO_URL}/commit/${version}`;
},

getUserGuideLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.HOME_PAGE_URL}/RepoSense/ug/index.html`;
}
return `${window.HOME_PAGE_URL}/ug/index.html`;
},
},
});

</script>
2 changes: 1 addition & 1 deletion frontend/src/styles/panels.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import 'z-indices';

.panel-padding {
padding: 0 1.5rem 2rem 2.2rem;
padding: 0 1.5rem 0 2.2rem;
}

#app-wrapper {
Expand Down
22 changes: 16 additions & 6 deletions frontend/src/styles/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ a.broken-link {
}

.tab-padding {
padding: 2rem 1.5rem;
padding: 2rem 1.5rem 0 1.5rem;
}

.widget-padding {
Expand Down Expand Up @@ -166,17 +166,28 @@ header {
text-align: center;
}

#app-name {
@include small-font;
color: mui-color('grey', '700');
height: 100%;
margin-bottom: 2em;
margin-left: 1em;
margin-top: 4em;
text-align: center;
}

#app-wrapper {
#summary-wrapper {
height: 100%;
overflow-y: scroll;
text-align: center;
text-align: left;

.timestamp-footer {
@include small-font;
@include mini-font;
color: mui-color('grey', '700');
margin-bottom: 1em;
margin-left: 1em;
margin-bottom: 1.2em;
margin-left: 2.4em;
margin-top: 1.2em;
}

.error-message-box {
Expand All @@ -187,7 +198,6 @@ header {
color: mui-color('red', '900');
margin-bottom: .9rem;
padding: .9rem;
text-align: left;

&__close-button {
@include large-font;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/styles/summary-chart.scss
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
}

.summary-charts {
margin-bottom: 1.4rem;
margin-bottom: 0;

&__title {
align-items: center;
Expand Down
52 changes: 7 additions & 45 deletions frontend/src/views/c-home.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,10 @@
v-bind:error-messages="errorMessages"
)
.timestamp-footer
span Generated by&nbsp;
a(
v-bind:href="getSpecificCommitLink()", target="_blank"
)
strong this version
span &nbsp;of&nbsp;
a(
v-bind:href="getRepoSenseHomeLink()", target="_blank"
)
strong RepoSense
span &nbsp;(
a(
v-bind:href="getUserGuideLink()", target ="_blank"
)
strong User Guide
span ) on {{ creationDate }}
.report-generation-time(style="display: none;")
span {{ reportGenerationTime }}
span Generated on {{ creationDate }}
.report-generation-time(style="display: none;")
span {{ reportGenerationTime }}
c-footer

template(v-slot:right)
#tabs-wrapper(ref="tabWrapper")
Expand Down Expand Up @@ -59,6 +45,7 @@
)
strong User Guide
| &nbsp; to get a better understanding of how to interpret the report.
c-footer

template(v-else)
.empty Please upload a .zip file generated by RepoSense.
Expand All @@ -75,6 +62,7 @@ import cResizer from '../components/c-resizer.vue';
import cZoom from './c-zoom.vue';
import cSummary from './c-summary.vue';
import cAuthorship from './c-authorship.vue';
import cFooter from '../components/c-footer.vue';

const home = defineComponent({
name: 'c-home',
Expand All @@ -84,6 +72,7 @@ const home = defineComponent({
cZoom,
cSummary,
cAuthorship,
cFooter,
},
props: {
updateReportZip: {
Expand Down Expand Up @@ -124,33 +113,6 @@ const home = defineComponent({
},
},
methods: {
getRepoSenseHomeLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.HOME_PAGE_URL}/RepoSense/`;
}
return `${window.HOME_PAGE_URL}`;
},

getSpecificCommitLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.REPOSENSE_REPO_URL}`;
}
if (version.startsWith('v')) {
return `${window.REPOSENSE_REPO_URL}/releases/tag/${version}`;
}
return `${window.REPOSENSE_REPO_URL}/commit/${version}`;
},

getUserGuideLink(): string {
const version = window.repoSenseVersion;
if (!version) {
return `${window.HOME_PAGE_URL}/RepoSense/ug/index.html`;
}
return `${window.HOME_PAGE_URL}/ug/index.html`;
},

getUsingReportsUserGuideLink(): string {
const version = window.repoSenseVersion;
if (!version) {
Expand Down
Loading