-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1832] Duplicate RepoSense links #2243
Conversation
Thanks for the PR, @jedkohjk As of now, I'm not sure any of the new alternatives proposed in this PR look particularly better than the original. Even duplicating the entire thing on both sides might not look particularly nice but at least it doesn't conflict with the original intention of the footer. On a related note, footers are normally shown in slightly smaller text than the rest of the page. So, we can consider doing that with out footer as well. |
Thanks for the review @damithc |
@damithc Yes. However, the welcome panel disappears upon clicking on a code panel or commits panel. It is not easy to get it back after clicking on these panels. After clicking on one of these panels, the easiest way to access a user guide will be the footer. A user may want to access the user guide after clicking on one of these panels to find out how to interpret the information on the panel. |
Hmm yes that makes sense. As of now, I'm not sure I know how to implement it though. |
Hi, should I close this PR as CP3108A is coming to an end for me? Also, basued on our discussions, should I mention adding the user guide in the header in issue #1832 for future reference, or create a new issue for it? |
The following links are for previewing this pull request:
|
Resolves #1832
Proposed commit message
Other information
Before:
After: