Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle lockfile #7875

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add gradle lockfile #7875

merged 1 commit into from
Mar 26, 2024

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Mar 19, 2024

Summary

Add gradle lockfile.

There are two ways to write the lock file:

  • Passing an argument to the android build (npm run android -- --extra-params --write-locks)
  • Running the dependencies task on gradle with write locks (android/gradlew app:dependencies --write-locks)

To update all current locks we can run the depdencies task with update locks:
android/gradlew app:dependencies --update-locks "*:*"

Ticket Link

Fix https://mattermost.atlassian.net/browse/MM-57196

Release Note

NONE

@larkox larkox added 2: Dev Review Requires review by a core commiter 3: Security Review Review requested from Security Team labels Mar 19, 2024
@enahum
Copy link
Contributor

enahum commented Mar 19, 2024

Lgtm but please document how to update it when adding/updating dependencies both direct and those included in RN libraries

@larkox
Copy link
Contributor Author

larkox commented Mar 19, 2024

@enahum Where do you think is the best place to document this?

@enahum
Copy link
Contributor

enahum commented Mar 19, 2024

@enahum Where do you think is the best place to document this?

@larkox Maybe the dev docs? And perhaps also in the description of the PR?

@esarafianou esarafianou requested review from jupenur and removed request for esarafianou March 19, 2024 10:52
@esarafianou
Copy link

@jupenur can you review the PR for Security?

@larkox larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: Security Review Review requested from Security Team labels Mar 26, 2024
@larkox larkox merged commit 0c31d22 into mattermost:main Mar 26, 2024
16 checks passed
@amyblais amyblais added this to the v2.16.0 milestone Mar 26, 2024
cyrusjc pushed a commit to cyrusjc/mattermost-mobile that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants