Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graddle lockfile update to the documentation #1350

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Mar 22, 2024

Summary

We add documentation on how to update the lock files.

This is dependent on mattermost/mattermost-mobile#7875

Ticket Link

NONE

@larkox larkox requested review from enahum and cwarnermm March 22, 2024 11:55
@larkox larkox added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Mar 22, 2024
Copy link

Newest code from larkox has been published to preview environment for Git SHA 7f288c4

We use lockfiles to lock dependencies and make sure the builds are reproductible. If we want to update the lockfile to update all dependencies to the latest, we can run these commands:
```
cd android
./gradlew app:dependencies --update-locks "*:*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we dont want the latests but the specific verdions we are using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific versions we are using would be already in the repo (in the lockfile).

If we want to generate them from the scratch (remove the lock file and regenerate it) we would call ./gradlew app:dependencies --write-locks. Is that what you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.. cause this is how I envision it.

Add a new dependency to the project or bump dependencies manually, then update the lock.. kind of the same we do with gems, cocoapods and npm

@cwarnermm cwarnermm removed the 2: Editor Review Requires review by an editor label Mar 22, 2024
@larkox larkox requested review from enahum and cwarnermm March 25, 2024 09:06
Copy link

Newest code from larkox has been published to preview environment for Git SHA 142aa81

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Mar 25, 2024
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 3eebeb6

@cwarnermm cwarnermm merged commit dea1c34 into master Mar 25, 2024
5 checks passed
@cwarnermm cwarnermm deleted the larkox-patch-1 branch March 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants