Session timeout notification incorrectly says "Days" on iOS #7510
Conversation
|
Hello @ShisuiMadara, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
You will also have to run |
|
@enahum for the hours one, should I write a logic like if the time is greater than 24 hours, we can notify like 1 day and x hours? Similarly for 722 hours it will say something like 30 days and 2 hours |
| const body = intl.formatMessage({ | ||
| id: 'mobile.session_expired', | ||
| defaultMessage: 'Please log in to continue receiving notifications. Sessions for {siteName} are configured to expire every {daysCount, number} {daysCount, plural, one {day} other {days}}.', | ||
| }, {siteName: serverName, daysCount: expiresInDays}); | ||
| defaultMessage: 'Please log in to continue receiving notifications. Sessions for {siteName} are configured to expire in {daysCount, number} {days} and {hoursCount, number} {hours}.', // Update the message |
There was a problem hiding this comment.
@esethna can you please advice on the message that we should use for hours and days ?
There was a problem hiding this comment.
We probably also need to remove the whole days part if the number of days is 0.
enahum
added
2: Dev Review
|
@ShisuiMadara I agree with @larkox when we have 0 days, the days part should not be part of the message. Also you have some tests failing |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@ShisuiMadara will you be making the changes suggested? |
|
Sorry @enahum you can assign it to someone else. I was expecting to close this earlier but now my schedule is too busy. |
|
@larkox can you take over or assign this to you team or HW? as you see fit really... |
Summary
When session expires, push notification says, “Please log in to continue receiving notifications. Sessions for test are configured to expire every 1 day.” Changed it to say hour.
Ticket Link
Fixes mattermost/mattermost#24112
Checklist
Device Information
This PR was tested on:
Screenshots
Release Note