Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make org picker functional #530

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Make org picker functional #530

merged 4 commits into from
Sep 27, 2024

Conversation

echappen
Copy link
Contributor

Changes proposed in this pull request:

  • Adds org picker component to org-related pages and makes it functional

How to test

  1. Log into cloudfoundry through the CLI
  2. Start a server using an updated cloud foundry token: npm run dev-cf

Switching orgs

  1. Navigate to an org-related page (like a manage users page)
  2. Open org picker and select another org
  3. New page should be an equivalent page to previous org

Viewing all orgs

  1. Navigate to an org-related page (like a manage users page)
  2. Open org picker and select "view all organizations"
  3. Should navigate you to /orgs

Screenshots

On Manage Users page

Screenshot 2024-09-25 at 1 16 29 PM

Related issues

Closes #410
Unblocks #408

Submitter checklist

  • Added logging is not capturing sensitive data and is set to an appropriate level (DEBUG vs INFO etc)
  • Updated relevant documentation (README, ADRs, explainers, diagrams)

Security considerations

None

Copy link
Contributor

@beepdotgov beepdotgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, but this is looking very good. Thanks for wiring this up so quickly, @echappen!

src/components/OrgPicker/OrgPicker.tsx Outdated Show resolved Hide resolved
src/components/OrgPicker/OrgPicker.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@beepdotgov beepdotgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🚀🎉

@echappen
Copy link
Contributor Author

@cannandev This is ready for a dev review whenever you're able

Copy link
Contributor

@cannandev cannandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome to see this come to life! LGTM 🚀

src/helpers/text.tsx Show resolved Hide resolved
@echappen echappen merged commit cb3d606 into main Sep 27, 2024
3 checks passed
@echappen echappen deleted the eoc/410 branch September 27, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revised navigation: org selection behavior
3 participants