48 simplify notch approximation lawbinned #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Maier <[email protected]>
Signed-off-by: Benjamin Maier <[email protected]>
Signed-off-by: Benjamin Maier <[email protected]>
johannes-mueller
requested changes
Jan 16, 2024
Comment on lines
696
to
701
| index = self._lut_primary_branch.load.searchsorted(np.abs(load.values))-1 # "-1", transform to zero-based indices | ||
|
|
||
| # raise error if requested load is higher than initialized maximum absolute load | ||
| if np.any(index+1 >= len(self._lut_primary_branch)): | ||
| raise ValueError(f"Binned class is initialized with a maximum absolute load of {self._maximum_absolute_load}, "\ | ||
| f" but a higher absolute load value of |{load.max()}| is requested (in stress()).") |
There was a problem hiding this comment.
Maybe we can ._find_load_index_or_raise(load) which finds the index of the load or raises if any of them is outside. Would remove code duplication and help readability.
Or at least introduce a method ._raise_if_requested_load_higher_than_max_abs_load(index, max_abs_load, max_load)
|
We should merge #67 ASAP to get the CI working again |
Signed-off-by: Benjamin Maier <[email protected]>
…o 48-simplify-notch_approximation_lawbinned Signed-off-by: Benjamin Maier <[email protected]>
|
I forgot the Sign-off again. Does it gets fixed with a squash? Then yes, please :-) |
johannes-mueller
deleted the
48-simplify-notch_approximation_lawbinned
branch
|
Ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.