Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify notch_approximation_law.Binned #48

Closed
johannes-mueller opened this issue Dec 5, 2023 · 0 comments · Fixed by #60
Closed

Simplify notch_approximation_law.Binned #48

johannes-mueller opened this issue Dec 5, 2023 · 0 comments · Fixed by #60
Assignees
@maierbn
Labels
code readability
Milestone
2.2.0

Comments

@johannes-mueller
Copy link
Member

johannes-mueller commented Dec 5, 2023 •
edited
Loading

This class has some duplicated code and some if ... elif ... else clauses which we should try to simplify.
@johannes-mueller johannes-mueller added this to the 2.2.0 milestone Dec 5, 2023
@maierbn maierbn linked a pull request Dec 21, 2023 that will close this issue
48 simplify notch approximation lawbinned #60
Merged
@johannes-mueller johannes-mueller closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maierbn maierbn

Labels
code readability
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

48 simplify notch approximation lawbinned boschresearch/pylife
2 participants
@johannes-mueller @maierbn