Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Refactoring docker-entrypoint.sh to Use Arrays for Configuration Parameters Instead of Eval and String Concatenation #188

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[hotfix] Refactoring docker-entrypoint.sh to Use Arrays for Configuration Parameters Instead of Eval and String Concatenation #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,19 @@ set_config_options() {
local bin_dir="$FLINK_HOME/bin"
local lib_dir="$FLINK_HOME/lib"

local config_params=""
local config_params=()

while [ $# -gt 0 ]; do
local key="$1"
local value="$2"

config_params+=" -D${key}=${value}"
config_params+=("-D${key}=${value}")

shift 2
done

if [ ! -z "${config_params}" ]; then
eval "${config_parser_script} ${config_dir} ${bin_dir} ${lib_dir} ${config_params}"
if [ "${#config_params[@]}" -gt 0 ]; then
"${config_parser_script}" "${config_dir}" "${bin_dir}" "${lib_dir}" "${config_params[@]}"
fi
}

Expand Down
Loading