[hotfix] Refactoring docker-entrypoint.sh to Use Arrays for Configuration Parameters Instead of Eval and String Concatenation #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincoln-lil
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
+1 (refers to the discussion on docker-library/official-images#16430)
docker-entrypoint.sh
Outdated
|
|
||
| while [ $# -gt 0 ]; do | ||
| local key="$1" | ||
| local value="$2" | ||
|
|
||
| config_params+=" -D${key}=${value}" | ||
|
|
…tion Parameters Instead of Eval and String Concatenation
JunRuiLee
force-pushed
the
refactor_docerk-entrypoint.sh
branch
from
999491d
to
66d75a3
Compare
|
Thanks @lincoln-lil for quick review, I've updated this pr accordingly, PTAL~ |
|
@JunRuiLee Thanks for the updates! LGTM, merging. |
|
@JunRuiLee Could you also create a backport pr for dev-1.19? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the docker-entrypoint.sh script as per the suggestions in the comments of docker-library/official-images#16430 (comment)