Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make tests that require binaries in path CI only #1393

Merged
merged 5 commits into from
Sep 30, 2024
Merged

test: make tests that require binaries in path CI only #1393

merged 5 commits into from
Sep 30, 2024

Conversation

prestwich
Copy link
Member

We had previously agreed NOT to add these tests as they require specific binaries in the user's $PATH

Motivation

Solution

  • Disable tests that require specific user environments, unless those tests are run in CI
  • break out a bunch of integration tests that were in-file as unit tests

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich self-assigned this Sep 27, 2024
@mattsse mattsse merged commit 32edd0c into main Sep 30, 2024
26 checks passed
@mattsse mattsse deleted the prestwich/node-tests branch September 30, 2024 08:06
@prestwich prestwich mentioned this pull request Sep 30, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@prestwich prestwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @mattsse