Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix more ci only #1402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests: fix more ci only #1402

wants to merge 2 commits into from

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Sep 30, 2024 •
edited
Loading

  • Disable more geth/reth tests when not run in CI
  • remove a bunch of bad-behavior init_tracing calls in tests to remove extraneous logs in test output

followup to #1393. That PR fixed cargo t this pr fixes cargo t --all-features

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich mentioned this pull request Sep 30, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prestwich