Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: add row_affinity support for the Row Affinity feature. #11839

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

djyau
Copy link
Contributor

@djyau djyau commented Sep 26, 2024

Bigtable: add row_affinity support for the Row Affinity feature.

Release Note Template for Downstream PRs (will be copied)

bigtable: added `row_affinity` field to `google_bigtable_app_profile` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 133 insertions(+))
google-beta provider: Diff ( 3 files changed, 132 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 0
Skipped tests: 47
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@NickElliot NickElliot self-requested a review September 26, 2024 21:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 106 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 105 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants