Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: add row_affinity support for the Row Affinity feature. #11138 #11801

Closed
wants to merge 8 commits into from

Conversation

djyau
Copy link
Contributor

@djyau djyau commented Sep 24, 2024

Bigtable: add row_affinity support for the Row Affinity feature.

Release Note Template for Downstream PRs (will be copied)

bigtable: added `row_affinity` field to `google_bigtable_app_profile` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 141 insertions(+))
google-beta provider: Diff ( 3 files changed, 141 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 0
Skipped tests: 47
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@c2thorn
Copy link
Member

c2thorn commented Sep 24, 2024

Hi @djyau

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself after the migration. You can view a preview branch and updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

@djyau
Copy link
Contributor Author

djyau commented Sep 26, 2024

Closing in lieu of #11839

@djyau djyau closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants