Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Assembler: Fix radio control height css issue #8186

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −0
Open

Theme Assembler: Fix radio control height css issue #8186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assembler/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ input:not([type=submit]):focus,
outline: 1px solid currentColor;
}

.wp-block-jetpack-contact-form-container input[type="radio"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this in a less specific way that works for all radio input forms.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the selector's example in the same style file that changes contact form fields.

themes/assembler/style.css

Lines 54 to 66 in 13e2539

.wp-block-jetpack-contact-form-container .wp-block-jetpack-contact-form label {
display: inline-block;
font-size: var(--wp--preset--font-size--small);
margin-bottom: 0.25em;
font-weight: inherit;
}
textarea,
input:not([type=submit]):not([type=checkbox]),
.wp-block-post-comments-form textarea,
.wp-block-post-comments-form input:not([type=submit]):not([type=checkbox]),
.jetpack-contact-form .jetpack-field .jetpack-field__input,
.jetpack-contact-form .jetpack-field .jetpack-field__textarea {

I found it safer since I'm not 100% familiar with this particular theme.

min-height: unset !important;
}

/* Jetpack Forms: Clean up errors */

.contact-form__error {
Expand Down
Loading