Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Assembler: Fix radio control height css issue #8186

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bogiii
Copy link

@bogiii bogiii commented Sep 18, 2024

Changes proposed in this Pull Request:

Fixes radio control height issue.

Before After
Screenshot 2024-09-18 at 17 34 43 Screenshot 2024-09-18 at 17 49 21

Related issue(s):

Closes #7959

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Assembler.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

assembler: No changes required ✅.

💡 RECOMMENDED (1)
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
ℹ️ INFO (1)
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is assembler.

@@ -89,6 +89,10 @@ input:not([type=submit]):focus,
outline: 1px solid currentColor;
}

.wp-block-jetpack-contact-form-container input[type="radio"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this in a less specific way that works for all radio input forms.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the selector's example in the same style file that changes contact form fields.

.wp-block-jetpack-contact-form-container .wp-block-jetpack-contact-form label {
display: inline-block;
font-size: var(--wp--preset--font-size--small);
margin-bottom: 0.25em;
font-weight: inherit;
}
textarea,
input:not([type=submit]):not([type=checkbox]),
.wp-block-post-comments-form textarea,
.wp-block-post-comments-form input:not([type=submit]):not([type=checkbox]),
.jetpack-contact-form .jetpack-field .jetpack-field__input,
.jetpack-contact-form .jetpack-field .jetpack-field__textarea {

I found it safer since I'm not 100% familiar with this particular theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembler: Single Choice Option Block's proportion is off/looks squeezed when the theme Assembler is active
2 participants