Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix comparison for classes implementing __eq__. #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] Fix comparison for classes implementing __eq__. #51

wants to merge 6 commits into from

Commits on Apr 2, 2019

  1. Update to current Python versions. 

    Additionally we have to pin an older `Sphinx` version to keep supporting
Python 2.
    Michael Howitz committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    5ae2445 View commit details
    Browse the repository at this point in the history

  2. Fix comparison for classes implementing __eq__. 

    There are currently only two new failing tests:

* Comparing an object with a proxy of the object fails (but comparing the proxy with the object is fine!)
* Comparing a proxy with itself fails

But these tests run fine when deleting the `__eq__` method on the `Something` class which is the class of `self.x`.
    Michael Howitz committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    4fc05a1 View commit details
    Browse the repository at this point in the history

  3. Unwrap other if it is a proxy, so the proxy can compare equal to itself.

    Michael Howitz committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7684a5f View commit details
    Browse the repository at this point in the history

  4. Fix pure Python implementation as suggested by @stephan-hof.

    Michael Howitz committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    f6baea7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2019

  1. Merge branch 'master' into issue-50

    Michael Howitz authored Apr 6, 2019
    Configuration menu
    Copy the full SHA
    f47558a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Merge branch 'master' into issue-50

    @icemac
    icemac authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    78332ec View commit details
    Browse the repository at this point in the history