Specify which Python versions are supported #192
Conversation
Clarify exactly which Python versions are supported, and add the classifiers that makes it clear in the sidebar on pypi.org.
torbsorb
requested review from
nedrebo,
trym-b,
eskaur and
apartridge
as code owners
| * [Python](https://www.python.org/) version 3.6 or higher | ||
| * [Python](https://www.python.org/) version 3.6, 3.7, 3.8, 3.9 and 3.10 |
There was a problem hiding this comment.
Slight complication to consider:
- We don't support 3.6 on Windows anymore (in the sense that we don't build, test & upload a .whl file for that). This is because 3.6 has been end-of-life for a while now.
- However, we do test Python 3.6 on Linux, because that's the default Python on Ubuntu 18.04 and we still support that.
Not saying we should talk about that complexity here. But unsure if 3.6 should be on the list or not.
There was a problem hiding this comment.
Also we support 3.11 on master now. Just hasn't been released to PyPI yet. So 3.11 should be listed here.
PyPI displays a snapshot of the Readme on the commit that is released.
There was a problem hiding this comment.
Opinions, @nedrebo ?
Should this list show the versions that we support somewhere, or just the versions that we support everywhere?
There was a problem hiding this comment.
Let's just do the union. Should now be "3.6, 3.7, 3.8, 3.9, 3.10 and 3.11"
There was a problem hiding this comment.
I think we should just drop 3.6 as it is already been EOL for over a year. Even 3.7 is almost EOL too
https://devguide.python.org/versions/
There was a problem hiding this comment.
It's the default Python on Ubuntu 18.04, so I suppose we should drop it when U18 is dropped.
There was a problem hiding this comment.
Let's do the ones that are fully supported. I.e that pip install will always work for Linux and Windows when on one of the listed Python versions.
Drop 3.6 here, but keep testing on "Ubuntu 18.04 / Python 3.6" to keep undocumented support best effort until we hit a real blocker for that support or until Zivid SDK drops support for 18.04.
| @@ -15,7 +15,7 @@ Zivid Python is the official Python package for Zivid 3D cameras. Read more abou | |||
|
|
|||
| ### Dependencies | |||
|
|
|||
| * [Python](https://www.python.org/) version 3.6 or higher | |||
| * [Python](https://www.python.org/) version 3.6, 3.7, 3.8, 3.9 and 3.10 | |||
There was a problem hiding this comment.
Also: Maybe it should say "or", not "and". Since it's "Dependencies", not "Supported versions".
| @@ -139,7 +139,11 @@ def _main(): | |||
| ], | |||
| classifiers=[ | |||
| "License :: OSI Approved :: BSD License", | |||
| "Programming Language :: Python :: 3", | |||
| "Programming Language :: Python :: 3.6", | |||
There was a problem hiding this comment.
Drop 3.6 and add 3.11 here also.
|
Not sure what I want with this, but have in mind that we also state which python we support here https://support.zivid.com/en/latest/api-reference/sdk-lifecycle.html#python depending on the OS. Take it into consideration when deciding what is the best for this PR, to avoid any confusion. |
Clarify exactly which Python versions are supported, and add the classifiers that makes it clear in the sidebar on pypi.org.