Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4552 Update CVarDumper.php for PHP 8.3 changes to highlight_string #4562

Closed

Conversation

ThePepster
Copy link
Contributor

PHP 8.3.0 The resulting HTML of highlight_string has changed.

'/&lt;\\?php<br \\/>/' no longer removes the "<?php\n" added when using highlight_string().

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@marcovtwout marcovtwout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a CHANGELOG line?

framework/utils/CVarDumper.php Show resolved Hide resolved
@marcovtwout
Copy link
Member

I'll merge this into #4553

marcovtwout added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants