Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for title undefined in merge options #7900

Closed
wants to merge 2 commits into from

Conversation

Niryo
Copy link
Contributor

@Niryo Niryo commented Aug 6, 2024

No description provided.

@asafkorem asafkorem changed the title added test for title undefined in merge options test: add test for title undefined in merge options Aug 13, 2024
@asafkorem asafkorem self-assigned this Aug 13, 2024
@asafkorem
Copy link
Collaborator

Issue comes from here: https://github.com/wix/react-native-navigation/blob/master/lib/Mock/Layouts/ParentNode.ts#L46-L48
We don't set the topbar title anywhere in this mock.. so it might come from there (this.data.options.topBar.title)

@Niryo
Copy link
Contributor Author

Niryo commented Aug 20, 2024

looks like e2e tests fail as well, so maybe it actually works? I need to check it against production and see what happens. closing for now

@Niryo Niryo closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants