Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure we don't swallow errors inside the mock #7899

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

Niryo
Copy link
Contributor

@Niryo Niryo commented Aug 6, 2024

adding {cause} should make it easier to understand where the error comes from.

@d4vidi
Copy link
Collaborator

d4vidi commented Aug 8, 2024

@Niryo the image link is broken

@Niryo
Copy link
Contributor Author

Niryo commented Aug 8, 2024

@d4vidi

try {
  throw new Error('this is the internal error!');
} catch(e) {
  throw new Error('Oops, something went wrong', { cause: e });
}
image

@asafkorem asafkorem changed the title make sure we don't swallow errors inside the mock fix: make sure we don't swallow errors inside the mock Aug 13, 2024
@asafkorem asafkorem merged commit 6c24560 into master Aug 13, 2024
6 checks passed
@asafkorem asafkorem deleted the Niryo-patch-1 branch August 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants