fix(iOS): avoid cutting-off text on bottom bar buttons on iPad. #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, this change resolves the issue in the attached snapshots. When `centered=YES`, setting the text alignment to `NSTextAlignmentCenter` may incidentally cause the text layout engine to more effectively manage the available space. Doesn't seem like it affects anything in iPhones. Overall, it seems like a bug in UIKit..
1 task
|
Thanks @phuongwd for finding this patch #7855 (comment) |
d4vidi
approved these changes
Mar 20, 2024
This was
linked to
issues
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, this change resolves the issue in the attached snapshots.
When
centered=YES, setting the text alignment toNSTextAlignmentCenter(see here) may incidentally cause the text layout engine to more effectively manage the available space. Doesn't seem like it affects anything in iPhones.Overall, it seems like a bug in UIKit..
Before:
After:
