Disable action-menu clipChildren=false #7860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #7832
After spending a fair amount of efforts trying to get a deep understanding the layout and view arrangement flow, i couldn't get to the very bottom of why the buttons menu transitively renders in a broken way, namely like this:
instead of:
Nevertheless,
clipChildren=false
over the action menu's root (i.e. theActionMenuView
class) - introduced here seems to be causing the flicker, while removing it doesn't seem to be introducing any regressions.Further steps
While with
clipChildren=false
the layout is broken transitively, removing it doesn't make all-things-perfect. There is still a very noticeable flicker happening in each stack push/pop, which could probably be avoided. Read below for hints as to why that is.Update: Reported in #7862
Some details for future reference:
ButtonBar#onLayout()
seems to be catching the app in with the visibility bug in-effect, meaning the menu layout phase is two-fold and that the button bar layout happening in between.Layouts
tab →Stack
button)