fix: support duplicate installations #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
changed the title
noomorph
force-pushed
the
fix/support-duplicate-installations
branch
from
591c42e
to
c372242
Compare
noomorph
changed the title
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rare issue discovered while testing #4212.
Sometimes, there might be duplicate
jest-metadatainstallations, even if the version is the same.This already creates a weird indeterministic behaviour, so this pull request improves the situation:
globalThisthe entire jest-metadata's realm objectglobalThis.This doesn't guarantee deterministic behaviour, but at least users will see the warning in the logs, so this type of misconfiguration can be spotted without deep debugging.