Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link to Contributing Guide #7279

Closed
wants to merge 2 commits into from
Closed

Conversation

danforbes
Copy link
Contributor

Closes #7266

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.67 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.26 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e88dd9e Previous: 6f9a485 Ratio
processingTx 22685 ops/sec (±8.72%) 21688 ops/sec (±8.58%) 0.96
processingContractDeploy 39249 ops/sec (±6.97%) 38621 ops/sec (±6.70%) 0.98
processingContractMethodSend 15841 ops/sec (±7.05%) 15698 ops/sec (±6.99%) 0.99
processingContractMethodCall 27897 ops/sec (±6.56%) 28405 ops/sec (±6.07%) 1.02
abiEncode 43410 ops/sec (±7.42%) 42626 ops/sec (±7.39%) 0.98
abiDecode 29689 ops/sec (±9.31%) 29174 ops/sec (±8.52%) 0.98
sign 1509 ops/sec (±3.48%) 1502 ops/sec (±3.88%) 1.00
verify 363 ops/sec (±0.55%) 364 ops/sec (±0.56%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (6f9a485) to head (e88dd9e).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7279   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2338     2338           
=======================================
  Hits         7992     7992           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex
Copy link
Contributor

can you also add these changes to the PR #7275

@danforbes
Copy link
Contributor Author

Closing in favor of #7275

@danforbes danforbes closed this Sep 23, 2024
@danforbes danforbes deleted the fix/link/contributing-guide branch September 23, 2024 14:14
@danforbes danforbes restored the fix/link/contributing-guide branch September 23, 2024 18:22
@danforbes
Copy link
Contributor Author

Reopening after discussion with @luu-alex

@danforbes
Copy link
Contributor Author

Closing in favor of #7283

@danforbes danforbes closed this Sep 23, 2024
@danforbes danforbes deleted the fix/link/contributing-guide branch September 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid contribution link. resulting in a 404 error
3 participants