Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of vocabulary files #243

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Update of vocabulary files #243

merged 2 commits into from
Feb 24, 2024

Conversation

iherman
Copy link
Member

@iherman iherman commented Feb 11, 2024

yml2vocab has now the ability of adding information on designated @context files that contain individual terms to the output. This change is adapted to this vocabulary.

Additionally, the vocabulary change takes care of #242 as well.

As usual, the automatic preview is useless for this case, see https://w3c.github.io/yml2vocab/previews/di/ for the new versions of the generated files.

@iherman iherman self-assigned this Feb 11, 2024
@iherman iherman added the CR1 This item was processed during the first Candidate Recommendation phase. label Feb 11, 2024
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a .drawio.bkp file erroneously checked in -- it should be removed before we merge this PR.

The rest of the changes look good. Thank you!

@msporny msporny added the editorial This issue or PR constitutes an editorial change. label Feb 19, 2024
@iherman
Copy link
Member Author

iherman commented Feb 20, 2024

There seems to be a .drawio.bkp file erroneously checked in -- it should be removed before we merge this PR.

Damn. But this is as old error of mine: the .bkp file only appears in the main branch, not this one. Do you want me to create a separate PR with that removal, or would you simply remove it with a direct commit in main?

(I have, since then, modified my .gitignore file to avoid this.)

@msporny
Copy link
Member

msporny commented Feb 24, 2024

I removed the backup file on main and rebased this branch on top. That's fixed now, re-reviewing...

@msporny
Copy link
Member

msporny commented Feb 24, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 936a53a into main Feb 24, 2024
1 check passed
@msporny msporny deleted the editorial-vocabulary-update branch February 24, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants