Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly pass secrets via environment variables to avoid them being visible in process lists #228

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Correctly pass secrets via environment variables to avoid them being visible in process lists #228

merged 3 commits into from
Oct 1, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 30, 2024

This was merged via a private branch because it was a security issue. CI doesn't run there and this slipped through.

Fixes: 25df787 ("Send passwords via environment variables")

@ekohl ekohl changed the title Fix syntax in pem_cert.pp Fix syntax in pem_cert.pp and correctly pass in a flat array Sep 30, 2024
@ekohl ekohl added the bug Something isn't working label Sep 30, 2024
@ekohl
Revert "Send passwords via environment variables"
41513a9 
This broke several things and needs some fixes.

This reverts commit 25df787.
@ekohl
Correctly pass in arguments as a single array
bae5c27 
Previously it used << with an array that ended up with a nested array.
Now it correctly uses += resulting in a single flat array.

Fixes: 6e1c856 ("Pass openssl commands as an array")
@ekohl
Copy link
Member Author

ekohl commented Sep 30, 2024

I'm not sure I like the "revert, fix prior commit & apply fixed commit", but it was the easiest for me to wrap my head around.

@ekohl
Reapply "Send passwords via environment variables"
b62720f 
This reverts commit 41513a9. The
previously implementation contained bugs and this is a proper fix.
@ekohl
Copy link
Member Author

ekohl commented Oct 1, 2024

Now updated with a link to puppetlabs/puppet#9493 in the comment.

@ekohl ekohl merged commit b16ac47 into voxpupuli:master Oct 1, 2024
28 checks passed
@ekohl ekohl deleted the fix-syntax branch October 1, 2024 13:45
@ekohl ekohl changed the title Fix syntax in pem_cert.pp and correctly pass in a flat array Correctly pass secrets via environment variables to avoid them being visible in process lists Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @bastelfreak