Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-mount support #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add multi-mount support #164

wants to merge 1 commit into from

Conversation

lschweiss-wustl
Copy link

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@lschweiss-wustl lschweiss-wustl mentioned this pull request Aug 19, 2020
Open
@vox-pupuli-tasks
Copy link

Dear @lschweiss-wustl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

dhollinger
dhollinger requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lschweiss-wustl could you fix the trailing whitespace in the README.md file? Also the stack edit comments should be removed from README.md and REFERENCE.md unless they are generated by Vox Pupuli tools.

Thanks!

README.md
<!--stackedit_data:
eyJoaXN0b3J5IjpbMTc1MTIxNDA2NCwtMTA3MDA1MzU4MCw1MD
g3NTE3MTQsMTEyOTIwODYyNywxMDI5MjkwNDQyXX0=
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this is from

REFERENCE.md
@@ -686,3 +689,6 @@ non-empty string or an array of such strings

Alias of `Variant[Pattern[/\A\S+\z/], Array[Pattern[/\A\S+\z/]]]`

<!--stackedit_data:
eyJoaXN0b3J5IjpbLTE5MDI5ODczMTldfQ==
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above. I'd rather these not be in the Documentation unless they come from the Vox Pupuli toolset.

@vox-pupuli-tasks
Copy link

Dear @lschweiss-wustl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhollinger dhollinger dhollinger requested changes

Assignees
No one assigned
Labels
merge-conflicts tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lschweiss-wustl @dhollinger