Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReadOnly flag from backupPod Volumes spec #8248

Conversation

shubham-pampattiwar
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@weshayutin
Copy link
Contributor

@shubham-pampattiwar @sseago nice work!

add changelog file

Signed-off-by: Shubham Pampattiwar <[email protected]>
@sseago
Copy link
Collaborator

sseago commented Sep 26, 2024

@Lyndon-Li this is the change that fixed backup on OpenShift without requiring privileged mode. ReadOnly mount is still preserved since the volumeMount entry still has ReadOnly with this change.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@11f771f). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8248   +/-   ##
=======================================
  Coverage        ?   59.21%           
=======================================
  Files           ?      367           
  Lines           ?    30840           
  Branches        ?        0           
=======================================
  Hits            ?    18261           
  Misses          ?    11119           
  Partials        ?     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li
Copy link
Contributor

@sseago @shubham-pampattiwar
See my comments here #8243 (comment). Let's do some further checks since the readOnly flags in volumeSource and volumeMount are for different purposes and literally should be both set.

@sseago
Copy link
Collaborator

sseago commented Sep 27, 2024

Closing in favor of #8250

@sseago sseago closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants