Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8232: ensure the ending event sinked before shutdown #8237

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8232, ensure the ending event sinked before shutdown

@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 23, 2024
@Lyndon-Li Lyndon-Li marked this pull request as ready for review September 23, 2024 10:15
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (3f9c2dc) to head (9deaa81).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/kube/event.go 82.53% 8 Missing and 3 partials ⚠️
pkg/datamover/backup_micro_service.go 50.00% 1 Missing ⚠️
pkg/datamover/restore_micro_service.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8237      +/-   ##
==========================================
+ Coverage   59.15%   59.20%   +0.05%     
==========================================
  Files         367      367              
  Lines       30777    30838      +61     
==========================================
+ Hits        18206    18259      +53     
- Misses      11113    11119       +6     
- Partials     1458     1460       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet merged commit 025d66d into vmware-tanzu:main Sep 24, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes target/1.15-rc.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants