Add the ConfigMap-specified parameters into velero install CLI #8201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
kind/changelog-not-required
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
from
34dee9f
to
69301c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8201 +/- ##
==========================================
- Coverage 59.21% 59.15% -0.06%
==========================================
Files 367 367
Lines 30708 30775 +67
==========================================
+ Hits 18184 18206 +22
- Misses 11069 11112 +43
- Partials 1455 1457 +2 ☔ View full report in Codecov by Sentry. |
blackpiglet
changed the title
ywk253100
reviewed
Sep 10, 2024
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
from
69301c2
to
3fac945
Compare
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
3 times, most recently
from
459b0ac
to
95f6f33
Compare
ywk253100
previously approved these changes
Sep 11, 2024
Lyndon-Li
previously approved these changes
Sep 11, 2024
blackpiglet
dismissed stale reviews from Lyndon-Li and ywk253100
via
08ab60f
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
2 times, most recently
from
08ab60f
to
5e93b10
Compare
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
from
5e93b10
to
e359e7b
Compare
|
@shubham-pampattiwar Please also help take a look. |
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
from
e359e7b
to
28eac37
Compare
Rename backup-repository-config to backup-repository-configmap. Rename repo-maintenance-job-config to repo-maintenance-job-configmap. Rename node-agent-config to node-agent-configmap. Add those three parameters to `velero install` CLI. Modify the design and the site documents. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
update_velero_install_parameter
branch
from
28eac37
to
68f3545
Compare
blackpiglet
changed the title
shubham-pampattiwar
approved these changes
Sep 12, 2024
Lyndon-Li
approved these changes
Sep 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.