Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Repo maintanence Job configuration. #8145

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Aug 22, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7758

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet changed the title Implement the Repo maintanence Job configuration design. Implement the Repo maintanence Job configuration. Aug 25, 2024
@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from 9f62b81 to 08f88ed Compare August 26, 2024 05:18
@blackpiglet blackpiglet force-pushed the 7758_implement branch 4 times, most recently from 1ccfbdc to de8455e Compare August 26, 2024 07:48
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 67.22689% with 117 lines in your changes missing coverage. Please review.

Project coverage is 59.21%. Comparing base (b92143d) to head (26cc41f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cli/install/install.go 0.00% 32 Missing ⚠️
pkg/repository/manager.go 69.52% 26 Missing and 6 partials ⚠️
pkg/cmd/server/server.go 0.00% 22 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 16 Missing ⚠️
pkg/repository/maintenance.go 73.91% 9 Missing and 3 partials ⚠️
pkg/exposer/csi_snapshot.go 85.71% 1 Missing and 1 partial ⚠️
pkg/util/kube/pod.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8145      +/-   ##
==========================================
- Coverage   59.23%   59.21%   -0.02%     
==========================================
  Files         367      367              
  Lines       30516    30708     +192     
==========================================
+ Hits        18076    18184     +108     
- Misses      10985    11069      +84     
  Partials     1455     1455              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from 2ad4147 to 690d330 Compare August 27, 2024 14:07
@github-actions github-actions bot added the Area/Design Design Documents label Aug 27, 2024
@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from ca317ec to ccadf59 Compare August 28, 2024 10:48
@blackpiglet blackpiglet marked this pull request as ready for review August 28, 2024 10:48
pkg/util/csi/util.go Outdated Show resolved Hide resolved
@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from 3a4f2a9 to 73f6a44 Compare August 31, 2024 12:45
@blackpiglet
Copy link
Contributor Author

@Lyndon-Li @anshulahuja98 @shubham-pampattiwar @kaovilai @sseago
This PR is ready. Please help take a look.

Lyndon-Li
Lyndon-Li previously approved these changes Sep 3, 2024
Copy link
Contributor

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❯ gh pr checkout 8145 
Switched to branch '7758_implement'

~/git/velero 7758_implement
❯ go list -f {{.Deps}} ./pkg/install/... | sed 's/ /\n/g' | grep -E 'aws|azure|gcp|s3'
k8s.io/client-go/plugin/pkg/client/auth/azure
k8s.io/client-go/plugin/pkg/client/auth/gcp

This would resolve @Frank51 issue #8157 for the most part.

@blackpiglet
Copy link
Contributor Author

@kaovilai @shubham-pampattiwar @Lyndon-Li @sseago @anshulahuja98
I added those parameters back and updated the documents.
PTAL.

pkg/install/deployment_test.go Outdated Show resolved Hide resolved
@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from e821d56 to cd70f9d Compare September 5, 2024 15:29
@blackpiglet blackpiglet force-pushed the 7758_implement branch 2 times, most recently from 494fbe6 to 7010575 Compare September 6, 2024 07:16
@blackpiglet
Copy link
Contributor Author

@sseago @shubham-pampattiwar
Could you please also take a look at this PR?

Remove the resource parameters from the velero server CLI.

Signed-off-by: Xun Jiang <[email protected]>
@blackpiglet blackpiglet merged commit 46801a0 into vmware-tanzu:main Sep 10, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The repo maintenance job should support node selector
4 participants