Issue 8072: restic deprecation - warning messages

[Lyndon-Li]

Fix issue #8072, add the warning messages for restic deprecation

[codecov]

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (2645948) to head (fefb4b8).
Report is 5 commits behind head on main.

Files	Patch %	Lines
pkg/cmd/cli/install/install.go	0.00%	3 Missing ⚠️
pkg/podvolume/backupper.go	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8096      +/-   ##
==========================================
- Coverage   58.78%   58.77%   -0.01%     
==========================================
  Files         358      358              
  Lines       30079    30084       +5     
==========================================
+ Hits        17681    17682       +1     
- Misses      10950    10954       +4     
  Partials     1448     1448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Lyndon-Li]

With this PR, users will see below warnings when --uploader-type=restic is specified during installation:
In the output of installation:
⚠️ Uploader 'restic' is deprecated, don't use it for new backups, otherwise, the backed up data may not be accessed by new versions of Velero

In Velero server log:
level=warning msg="Uploader 'restic' is deprecated, don't use it for new backups, otherwise, the backed up data may not be accessed by new versions of Velero

In the output of velero backup describe for a backup with fs-backup:

  Namespaces:
    <namespace>:   resource: /pods name: <pod name> message: /Uploader 'restic' is deprecated, don't use it for new backups, otherwise, the backed up data may not be accessed by new versions of Velero

And users will see below warnings when upgrading from v1.9 or lower:
In Velero server log:
level=warning msg="Uploader 'restic' is deprecated, don't use it for new backups, otherwise, the backed up data may not be accessed by new versions of Velero

In the output of velero backup describe for a backup with fs-backup:

  Namespaces:
    <namespace>:   resource: /pods name: <pod name> message: /Uploader 'restic' is deprecated, don't use it for new backups, otherwise, the backed up data may not be accessed by new versions of Velero

[reasonerjt]

@sseago any feedback for the wording?

[sseago]

@reasonerjt I'd replace "otherwise, the backed up data may not be accessed by new versions of Velero" with "otherwise this backup won't be available for restore when this functionality is removed in a future version of Velero"

[Lyndon-Li]

Done, thanks for the suggestion @sseago

[Lyndon-Li]

@sseago @shubham-pampattiwar Please help to review this PR and let me know how you feel about the warning messages.

[shubham-pampattiwar]

Please update the warning message in docs as well.
Ref: #8096 (comment)

[Lyndon-Li]

Done

[shubham-pampattiwar]

Update warning text in the docs

[shubham-pampattiwar]

/lgtm

Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init)                            
time="2024-08-09T20:28:35Z" level=info msg="setting log-level to INFO" logSource="pkg/cmd/server/server.go:199"                      
time="2024-08-09T20:28:35Z" level=info msg="Starting Velero server restic-warn (fefb4b858c796630428fb204a60b051f53fb1de6)" logSource=
"pkg/cmd/server/server.go:201"                                                                                                       
time="2024-08-09T20:28:35Z" level=info msg="1 feature flags enabled [EnableCSI]" logSource="pkg/cmd/server/server.go:203"            
time="2024-08-09T20:28:35Z" level=warning msg="Uploader 'restic' is deprecated, don't use it for new backups, otherwise the backups w
on't be available for restore when this functionality is removed in a future version of Velero" logSource="pkg/cmd/server/server.go:2
94"