Patch dbr's status when error happens #8086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
previously approved these changes
Aug 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8086 +/- ##
==========================================
- Coverage 58.80% 58.78% -0.03%
==========================================
Files 358 358
Lines 30085 30079 -6
==========================================
- Hits 17692 17681 -11
- Misses 10945 10950 +5
Partials 1448 1448 ☔ View full report in Codecov by Sentry. |
This commit makes sure the dbr's status is "Processed" when an error happens before the actual deletion is started fixes vmware-tanzu#7812 Signed-off-by: Daniel Jiang <[email protected]>
blackpiglet
approved these changes
Aug 6, 2024
ywk253100
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure the dbr's status is "Processed" when an error happens before the actual deletion is started
fixes #7812
#8029 has partially fixed the problem in #7812 but this PR handles more error conditions.
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.