Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mover micro service restore #8061

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Data mover micro service restore according to design #7576

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 59.12698% with 103 lines in your changes missing coverage. Please review.

Project coverage is 58.94%. Comparing base (8e0f4d1) to head (86e5480).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/cmd/cli/datamover/restore.go 42.71% 59 Missing ⚠️
pkg/datamover/restore_micro_service.go 70.06% 41 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8061      +/-   ##
==========================================
+ Coverage   58.91%   58.94%   +0.03%     
==========================================
  Files         353      354       +1     
  Lines       29643    29887     +244     
==========================================
+ Hits        17464    17617     +153     
- Misses      10738    10827      +89     
- Partials     1441     1443       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar
Copy link
Collaborator

@Lyndon-Li Will your next PR have the complete refactor and usage of podified data mover micro service backup/restore in place of the legacy data mover ?

@Lyndon-Li
Copy link
Contributor Author

@Lyndon-Li Will your next PR have the complete refactor and usage of podified data mover micro service backup/restore in place of the legacy data mover ?

Yes, with the next PR, the data mover ms will start to be functional for normal cases. And the restart case will be covered by a further PR.

@Lyndon-Li Lyndon-Li merged commit 54bd7ce into vmware-tanzu:main Aug 1, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants