Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Fix-issue-6297 #6477

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Lyndon-Li
Copy link
Contributor

Enhance the code because of #6297, the return value of GetBucketRegion is not recorded, as a result, when it fails, we have no way to get the cause

@Lyndon-Li Lyndon-Li changed the title Fix-issue-6297 [Cherry-pick] Fix-issue-6297 Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #6477 (dc5e9ef) into release-1.11 (286db70) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.11    #6477      +/-   ##
================================================
- Coverage         41.31%   41.30%   -0.02%     
================================================
  Files               251      251              
  Lines             23419    23425       +6     
================================================
  Hits               9676     9676              
- Misses            12984    12990       +6     
  Partials            759      759              
Impacted Files Coverage Δ
pkg/repository/config/aws.go 21.27% <0.00%> (-3.12%) ⬇️

@Lyndon-Li Lyndon-Li self-assigned this Jul 10, 2023
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jul 10, 2023
@Lyndon-Li Lyndon-Li force-pushed the release-1.11 branch 2 times, most recently from dc5e9ef to 20a69d4 Compare July 10, 2023 07:56
Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li Lyndon-Li marked this pull request as ready for review July 10, 2023 08:53
@reasonerjt reasonerjt merged commit 46a355c into vmware-tanzu:release-1.11 Jul 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants