Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for pre-post backup-restore action types #6466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nutrymaco
Copy link
Contributor

Please add a summary of your change

Add design doc after discussion in #6417

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added the Area/Design Design Documents label Jul 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #6466 (0392900) into main (e54a8af) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6466      +/-   ##
==========================================
- Coverage   60.18%   60.18%   -0.01%     
==========================================
  Files         229      229              
  Lines       24215    24219       +4     
==========================================
+ Hits        14575    14577       +2     
- Misses       8632     8634       +2     
  Partials     1008     1008              

see 4 files with indirect coverage changes

@sseago
Copy link
Collaborator

sseago commented Jul 8, 2023

Note that we already have an approved design for this (submitted via #4083 and currently located at https://github.com/vmware-tanzu/velero/blob/main/design/new-prepost-backuprestore-plugin-hooks.md)

I haven't reviewed this PR in detail yet, but was it created with reference to that one? If the prior design was insufficient, maybe it would be clearer to submit a PR that modifies that design rather than creates a complete new one.

@Nutrymaco Nutrymaco force-pushed the pre-post-backup-restore-action-types-design branch from e45652a to 0392900 Compare July 9, 2023 12:56
@Nutrymaco
Copy link
Contributor Author

@sseago

Yes, that makes sense, I've updated the current design. Сhanged the part about where to call the plugins considering async operations introduced in #5849 and #5993

@reasonerjt reasonerjt self-requested a review July 10, 2023 06:24
@anshulahuja98
Copy link
Collaborator

I went through the design. I get the overall objective.

Can you also highlight some concrete use cases where users need this. Secondly also look into adding rough Action / Action status structs as part of the design. So we get a better idea of the scope of actions we intend to support.

@Nutrymaco

@Nutrymaco
Copy link
Contributor Author

  1. Use cases:
    • stopping and resuming workload before and after backup
    • starting job after backup for data transfer to DR site
    • notifications about starting and finishing backup/restore
  2. Action status struct described here

@anshulahuja98

@Nutrymaco Nutrymaco force-pushed the pre-post-backup-restore-action-types-design branch from 0392900 to 90dd1da Compare July 31, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Design Design Documents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants