feat(combobox): add ability to group options #639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
force-pushed
the
kevin/combobox-grouped-options
branch
from
4c68b43
to
66f4698
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/combobox-grouped-options
branch
5 times, most recently
from
bc2f7f1
to
d37b026
Compare
Jinnie
reviewed
Apr 18, 2023
| '[style.display]': 'clrOptionItems.hasResults ? undefined : "none"', | ||
| }, | ||
| template: ` | ||
| <span class="clr-option-group-label" role="presentation">{{ label }}</span> |
There was a problem hiding this comment.
Not really sure about this, but it will probably be covered by Amy's suggestion for ariaLabeledBy?
| @@ -98,7 +98,7 @@ export class ClrOptions<T> implements AfterViewInit, LoadingListener, OnDestroy | |||
| @Input('id') optionsId: string; | |||
|
|
|||
| _items: QueryList<ClrOption<T>>; | |||
| @ContentChildren(ClrOption) | |||
| @ContentChildren(ClrOption, { descendants: true }) | |||
There was a problem hiding this comment.
I really hope no-one tries to nest comboboxes :D
There was a problem hiding this comment.
It can actually solve some problems, when people try to wrap options in their own component.
There was a problem hiding this comment.
I will look into that.
There was a problem hiding this comment.
Actually, nesting comboxes makes zero sense. So...
kevinbuhmann
force-pushed
the
kevin/combobox-grouped-options
branch
from
d37b026
to
ace8f2c
Compare
kevinbuhmann
force-pushed
the
kevin/combobox-grouped-options
branch
6 times, most recently
from
ead224c
to
ace8f2c
Compare
|
Any update on this pull request merge? |
|
Could this be prioritized for next minor version release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
PR Checklist
PR Type
Feature
What is the current behavior?
The combobox does not a built-in way to group options. Attempts to do this on the "consumer" side are hacky and and not fully accessible.
Issue Number: #635
What is the new behavior?
The combobox allows grouping options.
I used this example as guide: https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-grouped/
Does this PR introduce a breaking change?
No.