Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): improve screen reader text for stepnav items #1558

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Sep 19, 2024

  • Add "Step" before step number.
  • Replace untranslated step status icon labels with translated text.

PR Checklist

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

  • For uncompleted steps, the wizard step nav reads "1 [step title]". I doesn't read "step" before the step number.
  • For completed steps, the wizard step nav reads "complete 1 [step title] completed". The first "complete" is not translated, and the second one is redundant.
  • For steps with an error, the wizard step nav reads "error 1 [step title] error". The first "error" is not translated, and the second one is redundant.

Issue Number: CDE-2292

What is the new behavior?

  • For uncompleted steps, the wizard step nav reads "step 1 [step title]".
  • For completed steps, the wizard step nav reads "completed step 1 [step title]".
  • For steps with an error, the wizard step nav reads "error step 1 [step title]".

Does this PR introduce a breaking change?

The "Step" text will need to be translated. We don't count new common strings as breaking changes.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-stepnav-item-screen-reader branch 2 times, most recently from 67798b8 to 85ad332 Compare September 19, 2024 13:17
@kevinbuhmann kevinbuhmann marked this pull request as draft September 19, 2024 13:22
@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-stepnav-item-screen-reader branch 2 times, most recently from 0afa001 to 4f10c9a Compare October 3, 2024 14:39
- Add "Step" before step number.
- Replace untranslated step status icon labels with translated text.
@kevinbuhmann kevinbuhmann marked this pull request as ready for review October 3, 2024 15:02
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit 33bba6b into main Oct 3, 2024
8 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/wizard-stepnav-item-screen-reader branch October 3, 2024 15:49
Copy link
Contributor

github-actions bot commented Oct 3, 2024

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1558-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 33bba6b8055cc6ee0562fa2e42e04549e27a2bcc
# Push it to GitHub
git push --set-upstream origin backport-1558-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1558-to-16.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants