Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add gcc 14 support #1151

Merged
merged 11 commits into from
Aug 1, 2024
Merged

fix: add gcc 14 support #1151

merged 11 commits into from
Aug 1, 2024

Conversation

diegomrsantos
Copy link
Collaborator

@diegomrsantos diegomrsantos commented Jul 11, 2024 •
edited
Loading

Fixes #1150

@diegomrsantos diegomrsantos force-pushed the gcc-14-support branch 8 times, most recently from 47dcb80 to ca0d1e7 Compare July 18, 2024 18:23
@diegomrsantos diegomrsantos marked this pull request as ready for review July 29, 2024 10:57
@diegomrsantos diegomrsantos force-pushed the gcc-14-support branch 3 times, most recently from 03959fc to 681bb12 Compare July 29, 2024 17:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (02c96fc) to head (681bb12).
Report is 38 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1151    +/-   ##
========================================
  Coverage   84.53%   84.54%            
========================================
  Files          91       92     +1     
  Lines       15517    16416   +899     
========================================
+ Hits        13118    13879   +761     
- Misses       2399     2537   +138
Files Coverage Δ
libp2p/crypto/curve25519.nim 100.00% <100.00%> (ø)
libp2p/crypto/ecnist.nim 78.65% <40.00%> (+0.03%) ⬆️

... and 80 files with indirect coverage changes

@diegomrsantos diegomrsantos changed the title gcc 14 support fix: add gcc 14 support Aug 1, 2024
@diegomrsantos diegomrsantos merged commit 62f2d85 into master Aug 1, 2024
13 of 14 checks passed
@diegomrsantos diegomrsantos deleted the gcc-14-support branch August 1, 2024 12:50
AlejandroCabeza added a commit that referenced this pull request Aug 1, 2024
@AlejandroCabeza
Merge branch 'master' into feature/cleanup-ci
183c6a6 
* master:
  feat: adding onValidated observer (#1128)
  fix: add gcc 14 support (#1151)
  fix(ci): windows-amd64 (Nim version-1-6) (#1160)
AlejandroCabeza added a commit that referenced this pull request Aug 1, 2024
@AlejandroCabeza
Merge branch 'master' into debug/nimble-structure
da187bd 
* master:
  feat: adding onValidated observer (#1128)
  fix: add gcc 14 support (#1151)
  fix(ci): windows-amd64 (Nim version-1-6) (#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroCabeza AlejandroCabeza AlejandroCabeza approved these changes

@lchenut lchenut lchenut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
nim-libp2p
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GCC14
4 participants
@diegomrsantos @codecov-commenter @AlejandroCabeza @lchenut