Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md #6421

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update configuration.md #6421

wants to merge 3 commits into from

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 16, 2024

Description

What did you add/update/change?
Adding Umbraco UI Builder should be added to Startup.cs - not Program.cs.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@sofietoft
Copy link
Contributor

Thanks for the PR @bjarnef ! 💪

If I'm not mistaken, the Startup.cs file is not part of Umbraco 14. So, perhaps this should be added to a different version of the docs for this product? 🤔

@bjarnef
Copy link
Contributor Author

bjarnef commented Sep 16, 2024

@sofietoft yes, it seems you are correct.

I updated it in v13 instead, in v11 and v12 it did use Startup.cs.
However as Startup.cs can be used in existing/upgraded projects, I am in double if a clean v13 install use the new minimal API including only Program.cs.

@sofietoft
Copy link
Contributor

Yes, I believe you're right that the Startup.cs file can still be used in 13, so it make sense to update that article!
Instead of replacing Program.cs here, perhaps instead we could add a line saying something like:

Alternatively, if your project is upgraded from earlier versions, you can add the configuration to the Startup.cs file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants