Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transparant svg's in full window preview #16877

Open
wants to merge 1 commit into
base: v13/dev
Choose a base branch
from

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Aug 7, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes #16749

Description

This PR adds a css checkered background, as is quite standard for indicating full transparency, to the full window SVG rendering that replaced the direct linking to SVG's because of the security issue described in #6182

Testing

  • Create a new media item of type SVG
  • Upload an SVG with transparent elements or background to said item and save it.
  • go to the info app/tab and click on the link
  • the transparent parts of the SVG should be rendered as a checkered pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant