Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pm): bundle prosemirror packages into the pm package #5499

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Aug 15, 2024

Changes Overview

This is more of an experiment than anything, if we bundle all of the prosemirror packages instead of relying on dependencies to be resolved properly, we would fix CDN importing of tiptap as well as guaranteeing that a known set of good prosemirror packages work together.
The only issue is when people would want to use prosemirror packages separately from tiptap, because it is now a completely different instance things can break if they don't import from @tiptap/pm.

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#4873

Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: c0100cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit c0100cb
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66bdc73a62f3570008ad15ec
😎 Deploy Preview https://deploy-preview-5499--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111
Copy link
Contributor Author

After some more attempts at this, I think we will probably want to bundle the prosemirror packages but somehow have them still resolve to the @tiptap/pm/* packages, I tried with tsup & there is just not much flexibility. I think switching to rollup may be the only option. Probably would also have to build in dep order to have the packages that point to each other resolve properly, luckily there are no cycles between them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage open
Development

Successfully merging this pull request may close these issues.

1 participant