Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafety improvements #1683

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Unsafety improvements #1683

wants to merge 5 commits into from

Commits on Nov 6, 2023

  1. explicitly annotate lifetimes when unsafe is involved

    @Radvendii
    Radvendii committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b35b7cd View commit details
    Browse the repository at this point in the history

  2. use &'a lifetime rather than &'self 

    this simplifies things and eliminates a usage of `unsafe`.
    @Radvendii
    Radvendii committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d5970b0 View commit details
    Browse the repository at this point in the history

  3. correctly drop Array::IntoIter

    @Radvendii
    Radvendii committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b652cbe View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. revert earlier lifetime changes, but clarify comments

    @Radvendii
    Radvendii committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    60afe78 View commit details
    Browse the repository at this point in the history

  2. revert needless lifetimes

    @Radvendii
    Radvendii committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    2d2061a View commit details
    Browse the repository at this point in the history