Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded flexbug workaround #40876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Sep 27, 2024

Description

This was only needed for Internet Explorer.

REF: https://github.com/philipwalton/flexbugs#flexbug-4

Motivation & Context

Removing the unneeded & saves a couple of bytes. :-)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

This was only needed for Internet Explorer. Removing it saves a couple of bytes. :-)

REF: https://github.com/philipwalton/flexbugs#flexbug-4
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the unneeded & saves a couple of bytes. :-)

Every byte counts :-) Thanks for the PR, @coliff!
I won’t merge it immediately—just giving the @twbs/css-review team a chance to double-check if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants